✨machinepool: Add preflight checks for version skews - #14089
Open
rexagod wants to merge 1 commit into
Open
Conversation
kubernetes-prow
Bot
added
the
area/machinepool
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubernetes-prow
Bot
added
cncf-cla: yes
rexagod
changed the title
Adds preflight checks for version skews. To make this change convenient, I've made sure the implementation adhered to the existing patterns wherever relevant. This can be seen by contrasting this against the corresponding MachineSet implementation. However, because MachinePools differ from MachineSets in the order and representation of how owned resources are created and operated upon, most prominently, owing to the simple fact that the former does not control the lifecycle of its children in-house. Therefore, to maintain a clear initial baseline, I've kept the behavior from making any disruptive changes whatsoever, unlike MachineSets, since we do not exercise complete control over them. Instead, checks utilized conditions and events to exhibit failing states. Also, please note that I've tried to streamline things by introducing a condition that is consistent with MachinePool's current (v1beta1) condition plumbing, so it migrates when the rest do, in an attempt to not block this PR post-migration. Signed-off-by: Pranshu Srivastava <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Adds preflight checks for version skews. To make this change convenient, I've made sure the implementation adhered to the existing patterns wherever relevant. This can be seen by contrasting this against the corresponding MachineSet implementation.
However, because MachinePools differ from MachineSets in the order and representation of how owned resources are created and operated upon, most prominently, owing to the simple fact that the former does not control the lifecycle of its children in-house.
Therefore, to maintain a clear initial baseline, I've kept the behavior from making any disruptive changes whatsoever, unlike MachineSets, since we do not exercise complete control over them. Instead, checks utilized conditions and events to exhibit failing states.
Also, please note that I've tried to streamline things by introducing a condition that is consistent with MachinePool's current (v1beta1) condition plumbing, so it migrates when the rest do, in an attempt to not block this PR post-migration.
Tests and docs were generated using AI, but reviewed by a human.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #12732
/area machinepool