🌱 aggregate deleting condition messages from child resource - #14034
🌱 aggregate deleting condition messages from child resource#14034sivchari wants to merge 1 commit into
Conversation
Signed-off-by: sivchari <[email protected]>
|
This PR is currently missing an area label, which is used to identify the modified component when generating release notes. Area labels can be added by org members by writing Please see the labels list for possible areas. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
kubernetes-prow
Bot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubernetes-prow
Bot
added
the
size/L
elmiko
left a comment
elmiko
left a comment
There was a problem hiding this comment.
this generally makes sense to me, i'm not exactly sure on the delete message mechanics but overall i think the code makes sense.
i do have a minor question.
|
|
||
| childDeleting, err := UnstructuredGet(child, clusterv1.DeletingCondition) | ||
| if err != nil || childDeleting == nil || childDeleting.Status != metav1.ConditionTrue || childDeleting.Message == "" { | ||
| return baseMessage |
There was a problem hiding this comment.
should we expose the error here?
not sure if it makes sense.
2 participants
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #11900