website: Add GSoC 2026 logo to navbar#4418
Conversation
Signed-off-by: Ishan <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @Ishan-AI-coder. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
🚫 This command cannot be processed. Only organization members or owners can use the commands. |
Signed-off-by: Ishan <[email protected]>
|
Thanks for the ok-to-test, @Arhell! 🙏 |
There was a problem hiding this comment.
Pull request overview
Adds GSoC 2026 branding and status to the main navbar.
Changes:
- Adds the GSoC logo, label, and ongoing badge.
- Links the navbar entry to the GSoC 2026 event page.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| weight = -900 | ||
| pre = "<i class='fas pr-2'><img src='/docs/images/logos/gsoc.svg' style='height: 1.22em;'></i>" | ||
| post = "<br><span class='badge badge-success'>Ongoing</span>" | ||
| url = "/events/upcoming-events/gsoc-2026/" |
| [[menu.main]] | ||
| name = "GSoC 2026" | ||
| weight = -900 | ||
| pre = "<i class='fas pr-2'><img src='/docs/images/logos/gsoc.svg' style='height: 1.22em;'></i>" |
There was a problem hiding this comment.
Thanks for catching those issues @juliusvonkohout !
It turns out the stable URL front matter wasn't included in the earlier diff, and the navbar was linking to the directory-derived path instead of the stable URL, so the two didn't match.
I have pushed a commit which addresses all of the feedback by:
- Adding
url = "/events/gsoc-2026/"to the front matter ofgsoc-2026.md, matching the existing GSoC 2025 convention. - Updating the navbar entry in
config.tomlto point to the same stable path (/events/gsoc-2026/) instead of the directory-derived path (/events/upcoming-events/gsoc-2026/). - Setting
alt=""for the decorative GSoC logo image, as suggested.
Testing
Verified locally by running:
hugo server -DAll changes render correctly, and the navbar now points to the stable URL.
Signed-off-by: Ishan <[email protected]>
|
I am not sure there is a lot of benefit to have a link which has no action possible right now (as GSOC is already in progress, not accepting applications)? |
|
That's a fair point @thesuperzapper — since applications aren't open, a navbar link without a clear next step probably isn't worth adding right now. Happy to close this PR, or hold it and reopen closer to a phase where the link would actually be actionable (e.g. results announcement or the next application window). Let me know what you'd prefer, or I can just close it. |
Fixes #4351
What this PR does
Adds the GSoC 2026 logo, label, and "Ongoing" status badge to the top navbar,
using the same pattern previously used for GSoC 2025 (which was already
present in
config.tomlas a commented-out template).[[menu.main]]entry inconfig.tomlto pointto GSoC 2026 (logo, label, badge).
urlfront-matter field tocontent/en/events/upcoming-events/gsoc-2026.md, matching the conventionused in the 2024/2025 GSoC event pages, so the link won't break once this
page moves to
/past-events/.Testing
Built and previewed locally with
hugo serverand verified the navbarrenders the logo, label, and badge correctly, linking to
/events/gsoc-2026/without a 404. Also confirmed
hugo --gc --minifycompletes cleanly.Notes
I'd asked on the issue whether this was still wanted but hadn't gotten a
response yet — opening this PR now so there's concrete code to review.
Happy to close or rework if this turns out to be unnecessary.