Skip to content

fix: add requirements.txt and replace hardcoded paths in government example#583

Open
31groot wants to merge 1 commit into
kubeedge:mainfrom
31groot:fix/government-example-paths-and-requirements
Open

fix: add requirements.txt and replace hardcoded paths in government example#583
31groot wants to merge 1 commit into
kubeedge:mainfrom
31groot:fix/government-example-paths-and-requirements

Conversation

@31groot

@31groot 31groot commented Jul 17, 2026

Copy link
Copy Markdown

What type of PR is this?
/kind documentation

What this PR does / why we need it:
The government example had two issues:

  1. No requirements.txt — contributors hit ModuleNotFoundError for
    torch, transformers, numpy, tqdm, and openai with no guidance.

  2. Hardcoded absolute paths (/home/icyfeather/...) in 4 YAML files
    (2 benchmarkingjob.yaml, 2 testenv.yaml) making benchmarks non-runnable
    on any machine except the original developer's.

Both objective and subjective sub-examples are fixed.

Which issue(s) this PR fixes:
Fixes #563

@kubeedge-bot kubeedge-bot added the kind/documentation Categorizes issue or PR as related to documentation. label Jul 17, 2026
@kubeedge-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 31groot
To complete the pull request process, please assign moorezheng after the PR has been reviewed.
You can assign the PR to them by writing /assign @moorezheng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gemini-code-assist

Copy link
Copy Markdown

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@kubeedge-bot kubeedge-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 17, 2026
@31groot

31groot commented Jul 17, 2026

Copy link
Copy Markdown
Author

/assign @MooreZheng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/documentation Categorizes issue or PR as related to documentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Core setup failures on fresh install: API rename, missing class, wrong docs path, undocumented deps

3 participants