fix: add requirements.txt and replace hardcoded paths in government example#583
Open
31groot wants to merge 1 commit into
Open
fix: add requirements.txt and replace hardcoded paths in government example#58331groot wants to merge 1 commit into
31groot wants to merge 1 commit into
Conversation
…xample Signed-off-by: Parv Agrawal <[email protected]>
Collaborator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 31groot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Author
|
/assign @MooreZheng |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
The
governmentexample had two issues:No
requirements.txt— contributors hitModuleNotFoundErrorfortorch, transformers, numpy, tqdm, and openai with no guidance.
Hardcoded absolute paths (
/home/icyfeather/...) in 4 YAML files(2 benchmarkingjob.yaml, 2 testenv.yaml) making benchmarks non-runnable
on any machine except the original developer's.
Both
objectiveandsubjectivesub-examples are fixed.Which issue(s) this PR fixes:
Fixes #563