Improve reqwest usage & errors - #68
Merged
Merged
Conversation
…or reqwest and serde
sour-dani
approved these changes
Jul 27, 2026
sour-dani
left a comment
sour-dani
left a comment
Collaborator
There was a problem hiding this comment.
LGTM
Will be nice to see more verbose reqwest error messages
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the usage of
reqwestwhen fetchingversions.jsonso it actually sends the user agent defined insrc/lib.rs. This PR also improves some of the data stored in errors, so if there's aBeansError::SerdeJsonthrown/returned, then it'll include the content it was trying to deserialise. The errorReqwestalso now includes an error message field, so more information can be described when returning that error.Along with this, the user agent has been updated to include the sourcemod name, so the user agent for Open Fortress would be
beans-rs/1.7.3 (open_fortress).