Skip to content

Update to latest version of nightly & update packages - #67

Merged
sour-dani merged 1 commit into
developfrom
feature/sentry-enable-logs
Jul 30, 2026
Merged

Update to latest version of nightly & update packages#67
sour-dani merged 1 commit into
developfrom
feature/sentry-enable-logs

Conversation

@ktwrd

@ktwrd ktwrd commented May 9, 2026

Copy link
Copy Markdown
Owner

Important

Depends on #66

Logging is already implemented for Sentry, but it's not enabled. This PR just enables the option when initialising the Sentry SDK so crash logs are actually submitted (which my glitchtip instance now supports, yay!)

@ktwrd ktwrd added the enhancement New feature or request label May 9, 2026
@ktwrd ktwrd assigned ktwrd and unassigned ktwrd May 9, 2026
@ktwrd
ktwrd requested a review from sour-dani July 27, 2026 04:45
Comment thread Cargo.toml Outdated
@sour-dani
sour-dani self-requested a review July 28, 2026 04:09
sour-dani
sour-dani previously approved these changes Jul 28, 2026

@sour-dani sour-dani left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ktwrd
ktwrd dismissed sour-dani’s stale review July 28, 2026 04:11

The merge-base changed after approval.

@sour-dani sour-dani left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Had to resubmit due to prior merge.

@sour-dani
sour-dani self-requested a review July 28, 2026 04:12
sour-dani
sour-dani previously approved these changes Jul 28, 2026

@sour-dani sour-dani left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prior review was not considered.

@ktwrd
ktwrd dismissed sour-dani’s stale review July 28, 2026 04:16

The merge-base changed after approval.

@sour-dani
sour-dani self-requested a review July 29, 2026 04:05
sour-dani
sour-dani previously approved these changes Jul 29, 2026
@ktwrd
ktwrd dismissed sour-dani’s stale review July 29, 2026 04:06

The merge-base changed after approval.

@sour-dani
sour-dani self-requested a review July 29, 2026 04:07
@sour-dani
sour-dani self-requested a review July 29, 2026 04:09
sour-dani
sour-dani previously approved these changes Jul 29, 2026
@sour-dani

Copy link
Copy Markdown
Collaborator

GitHub is a functional website

@ktwrd
ktwrd dismissed sour-dani’s stale review July 29, 2026 04:11

The merge-base changed after approval.

@sour-dani
sour-dani marked this pull request as draft July 29, 2026 04:12
@sour-dani
sour-dani marked this pull request as ready for review July 29, 2026 04:12
@sour-dani
sour-dani self-requested a review July 29, 2026 04:12
sour-dani
sour-dani previously approved these changes Jul 29, 2026
@sour-dani
sour-dani self-requested a review July 29, 2026 04:15
sour-dani
sour-dani previously approved these changes Jul 29, 2026
@sour-dani
sour-dani dismissed their stale review July 29, 2026 04:16

GitHub Is Busted

@ktwrd ktwrd closed this Jul 30, 2026
@ktwrd ktwrd reopened this Jul 30, 2026
@sour-dani
sour-dani self-requested a review July 30, 2026 16:22
@sour-dani
sour-dani merged commit 6ff794e into develop Jul 30, 2026
6 checks passed
@sour-dani sour-dani mentioned this pull request Aug 10, 2026
@sour-dani
sour-dani deleted the feature/sentry-enable-logs branch August 14, 2026 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants