chore: package releases for fork#61
Open
kruton wants to merge 1 commit into
Open
Conversation
This will help users reporting bugs and identifying which version they are running on their local system.
There was a problem hiding this comment.
Pull request overview
This PR adds a fork-specific version identifier that gets embedded at build time (via CMake and a fork_version.txt in source archives) and surfaced in runtime diagnostics and /version-style outputs, improving bug report fidelity for packaged releases of this fork.
Changes:
- Introduces a CMake-driven
TF_FORK_VERSION(andfork_version.txtfor source archives) to consistently identify fork builds. - Displays the fork version in startup banners,
/versionoutput, internal error messages, and core dump metadata. - Extends CI packaging workflow to publish a GitHub Release on
v*tags with built artifacts and a source archive.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/varlist.h | Adds a TF_FORK_VERSION variable entry. |
| src/tfio.c | Includes fork version in internal error messages. |
| src/tfdefs.h.in | Adds build-time defines for fork version. |
| src/tf.h | Exposes fork_version as a global extern. |
| src/signals.c | Writes fork version into crash dump metadata. |
| src/main.c | Prints fork version in startup output (stdout and screen). |
| src/globals.h | Adds convenience accessor macro for the new variable. |
| src/globals.c | Defines fork_version from the configured macro. |
| src/command.c | Prints fork version in the version command output. |
| packaging/make-source-archive.sh | Appends fork_version.txt into generated source tarballs. |
| CMakeLists.txt | Computes/configures TF_FORK_VERSION from fork_version.txt, git tags, or commit hash. |
| .github/workflows/packages.yml | Adds a tag-triggered release job that bundles artifacts and creates a GitHub Release. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+69
to
+73
| # Append fork_version.txt to the tarball under the prefix directory | ||
| mkdir -p "${prefix}" | ||
| echo "${FORK_VERSION}" > "${prefix}/fork_version.txt" | ||
| tar -rf "$tmp_tar" "${prefix}/fork_version.txt" | ||
| rm -rf "${prefix}" |
Comment on lines
+258
to
+260
| - name: Checkout source | ||
| uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3 | ||
|
|
Comment on lines
+306
to
+308
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| run: | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will help users reporting bugs and identifying which version they are running on their local system.