(workflowbar-autohide) Floating pill styling and welcome/empty-state autohide gate#245
Merged
Conversation
In autohide mode the revealed row now detaches from the edges — a horizontal inset + small top gap (--space tokens), rounded corners (--radius-lg), an elevated surface (--bg-elevated), a drop shadow (--shadow-lg) and a resting accent phosphor glow — so it reads as a floating capsule rather than a docked edge-to-edge strip. The phosphor keyframe settles onto the resting glow (no snap), and the hidden transform clears the top gap while dropping the shadow so nothing peeks past the top edge. The in-flow bar (autohide off) is unchanged. No new theme keys; light + dark.
The bar could slide away while only the welcome card (or an empty workspace) was showing — hiding navigation with nothing behind it to uncover, and leaving a mouse user no way in on first run. useAutoHide now takes a hasContent flag that gates it exactly like the enabled opt-out: false keeps the bar revealed with no timer, and a false→true flip (a view opens) starts it. FlexLayoutWorkspace derives hasContent as !showLanding && tabCount > 0 (tabCount tracked alongside the existing empty-workspace fallback) and passes it through. Adds hook tests for the gate and updates the docs (this also subsumes the Nagelfar first-run reachability residual).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two findings from the owner's visual pass of #244.
hasContent = !showLanding && hasTabs, same mechanism as the enabled flag; the timer starts on the false→true transition). This also resolves the first-run reachability residual from (workflowbar-autohide) Autohide the workflow bar with retro slide + phosphor #244's review.Testing
npm test: 91 files / 886 tests passed (3 new hasContent hook tests)npm run build:workspace: OK