(step-layout-memory) Per-step layout memory, landing trim and series doc sweep#240
Merged
Conversation
The always-visible WorkflowBar already provides the pipeline steps, the working-set chip, the Fortsatt continuation and the Verktyg tools menu at all times — including on an empty workspace. Re-rendering the step grid, tools grid and continue row on the landing only duplicated the bar (the double-Fortsatt-buttons problem). Reduce StartupLanding to a pure welcome/orientation card: title, subtitle and a hint pointing at the bar. It no longer needs backend, moduleAPI or working-folder wiring. The bar is the single source for navigation and continuation.
Each pipeline step (import/rename/review/count/culling) now remembers the
shape the user leaves it in — an extra pane, changed pane weights — and
restores it on re-entry instead of the bare factory layout (Capture One
workspaces pattern, Nielsen N7).
stepLayoutMemory.js stores one pane spec per step under
ansikten-workspace-<step>. A spec ({ moduleId, weight }[]) — not a full
model — feeds the existing non-destructive morph, so restoring a
remembered layout preserves live module state and the parked-in-background
semantics. A snapshot reads only real tabsets, so border-parked Bakgrund
tabs never leak into a step's memory. resolveStepSpec merges saved with
factory so a step's essential modules can never go missing.
Persistence is scoped and settled: handleModelChange writes the active
step's spec on real user changes only (programmatic morphs are suppressed);
changes with no active step are not remembered. Mount always builds the
neutral default preset — memory surfaces only when a step is entered. The
legacy ansikten-flexlayout key is migrated once into review's memory, then
removed.
Reset layout now forgets the current step's memory and rebuilds it to
factory; new Reset all layouts (Window menu) forgets every step. Both keep
the dirty-Review confirm.
The command-table entries layout-full-review and layout-template-full-image are inert — no menu item dispatches them any more (Helbild was removed from the Layoutmallar submenu when the workflow bar took over Cmd+1..5). Remove them and the now-unused menu.window.fullImage i18n key.
- ux-principles.md: navigation rules 7 (per-step memory) and 8 (landing is orientation, not navigation); reset semantics in rule 3 updated to morph-to-factory for a step; N4/N7 reflect the bar as the single nav source. - workspace-guide.md: per-step layout memory + Reset all layouts; startsida rewritten as a welcome card pointing at the bar. - ROADMAP.md: drop the delivered Arbetsflodes-layoutpresets item; refresh the FileQueue n/p entry (companion foundation exists via the role catalog, the gate itself remains a future PR). - CHANGELOG.md: Added (per-step memory), Changed (landing trim), Removed (dead menu commands + fullImage key).
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sixth and final PR in the navigation-overhaul series (#235–#239).
ansikten-workspace-<step>; re-entering a step morphs toward your saved arrangement instead of the factory spec. "Återställ layout" resets only the current step (dirty-confirm kept). The legacyansikten-flexlayoutkey is migrated and removed; corrupt saves fall back to factory. Parked "Bakgrund" tabs belong to the live model and are stripped from step snapshots so old parkings can't resurrect from memory.layout-full-review/layout-template-full-imagecommand-table entries and the unusedmenu.window.fullImagei18n key removed (flagged in (workspace-morph) Morph layouts on step switch instead of replacing the model #237's review).Testing
npm test: 88 files / 832 tests passed (new: per-step round-trip, migration, corrupt fallback, border-strip, reset scoping, landing regression)npm run build:workspace: OK