feat: verify CLI checksums and normalize leading v on exact pins#30
Merged
Conversation
Two follow-ups from the PR review: 1. Checksum verification: the downloaded asset is now checked against the release's kosli_<version>_checksums.txt (SHA-256) before extraction; a mismatch fails the action. Releases publish checksums but no signatures, so this is the available integrity mechanism. If a release publishes no checksums file (very old versions), we warn and continue rather than break the install. Adds getAssetFilename/getChecksumsUrl/verifyChecksum helpers (getDownloadUrl reuses getAssetFilename) with unit tests. 2. Exact pins: "v2.11.43" was returned verbatim, producing a broken download URL (.../download/vv2.11.43/...). The leading v is now stripped so it matches the latest/partial paths; literal tags like "Latest" stay unchanged.
mbevc1
changed the title
v on exact pins
AlexKantor87
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two follow-ups from the PR review:
Checksum verification: the downloaded asset is now checked against the release's
kosli_<version>_checksums.txt(SHA-256) before extraction; a mismatch fails the action. Releases publish checksums but no signatures, so this is the available integrity mechanism. If a release publishes no checksums file (very old versions), we warn and continue rather than break the install. AddsgetAssetFilename/getChecksumsUrl/verifyChecksumhelpers (getDownloadUrlreusesgetAssetFilename) with unit tests.Exact pins:
v2.11.43was returned verbatim, producing a broken download URL (.../download/vv2.11.43/...). The leading v is now stripped so it matches the latest/partial paths; literal tags likelateststay unchanged.