feat(cli): add Service Account commands#973
Open
mbevc1 wants to merge 3 commits into
Open
Conversation
Add CLI commands wrapping the new service account management endpoints (kosli-dev/server#5951): create, list, get, update and delete service accounts. Previously the CLI could only manage a service account's API keys, not the accounts themselves. - create/list/get/delete added under the existing verbs - update added under a new `update` parent command (registered in root) - shared models and table printers in `serviceAccount.go`, mirroring `apiKey.go` - httpfake-backed tests plus response fixtures under testdata/service-account
Contributor
|
Claude finished @mbevc1's task in 2m 48s —— View job Review: Service Account commands
Static analysis ✅
What's good 👍
Minor / optional
Bug checkNo correctness issues found. Dry-run correctly skips both the confirmation prompt and the "was deleted" message; batch delete reports the right prefix ( Overall this is a clean, well-tested PR that follows the repo's established patterns. The only items are optional polish. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add CLI commands wrapping the new service account management endpoints (kosli-dev/server#5951): create, list, get, update and delete service accounts. Previously the CLI could only manage a service account's API keys, not the accounts themselves.
updateparent command (registered in root)serviceAccount.go, mirroringapiKey.go