chore: align compliance status messages to NON-COMPLIANT#970
Merged
Conversation
For ENV and snapshot assertions the CLI printed INCOMPLIANT, which did not match the NON-COMPLIANT framing used in the UI and elsewhere in the CLI. Align the wording in `assert snapshot` and `get environment`. Closes #969
Contributor
|
Claude finished @mbevc1's task in 1m 11s —— View job Review: align compliance status to NON-COMPLIANT
✅ LGTM. This is a clean, well-scoped wording fix that does exactly what it says. Findings
Minor observations (non-blocking, out of scope for this PR)
Nice, tightly-scoped customer-facing fix — test and production code changed in lockstep. |
mbevc1
added a commit
to kosli-dev/docs
that referenced
this pull request
Jun 24, 2026
Adds a "Don't parse the raw CLI output" section to the Querying Kosli tutorial, advising readers to use exit codes or `--output json` rather than grepping human-readable output (e.g. `COMPLIANT`/`NON-COMPLIANT`/`INCOMPLIANT`). This avoids scripts silently breaking when wording is tweaked between CLI versions (context: internal discussion around kosli-dev/cli#970). <!-- mintlify-agent-attribution --> --- Generated by Mintlify Agent. Requested by: [email protected] via Slack Mintlify session: slack_1782312639.838479_C0AJTQ5633K --------- Co-authored-by: mintlify[bot] <109931778+mintlify[bot]@users.noreply.github.com> Co-authored-by: Marko Bevc <[email protected]> Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: Marko Bevc <[email protected]>
Contributor
Author
|
Related docs change: kosli-dev/docs#290 |
pbeckham
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For ENV and snapshot assertions the CLI printed INCOMPLIANT, which did not match the NON-COMPLIANT framing used in the UI and elsewhere in the CLI. Align the wording in
assert snapshotandget environment.Closes #969