Show new overview sections on the Home screen#203
Conversation
koel's overview API now also returns latest/random/recently-added albums and artists, plus new/least-played/random/similar songs. Parse every section (missing keys stay empty so older servers degrade gracefully) and render each non-empty block as a card scroller, ordered to match koel web's default home layout.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughOverviewProvider now tracks additional media sections. User preferences store Home block ordering, while HomeScreen renders expanded sections in the saved order with configurable Hero behavior for repeated cards. ChangesOverview sections and Home block preferences
Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant OverviewProvider
participant OverviewAPI
participant RecentlyPlayedProvider
participant AuthProvider
participant HomeScreen
participant CardWidgets
OverviewProvider->>OverviewAPI: request categorized media lists
OverviewAPI-->>OverviewProvider: return overview payload
OverviewProvider->>RecentlyPlayedProvider: seed recently played songs
OverviewProvider-->>HomeScreen: notify refreshed sections
AuthProvider-->>HomeScreen: provide saved block order
HomeScreen->>HomeScreen: build and reorder media blocks
HomeScreen->>CardWidgets: render cards with Hero settings
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
lib/providers/overview_provider.dart (1)
82-100: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winRename lambda parameter
jto a descriptive name.Per the coding guidelines,
jis only permitted for loop counters; lambda args and callback params should use descriptive names. In.map<Album>((j) => Album.fromJson(j))and.map<Artist>((j) => Artist.fromJson(j)),jis a lambda parameter representing a JSON entry, not a loop counter.♻️ Proposed rename
List<Album> _parseAlbums(dynamic json) => _albumProvider.syncWithVault( ((json ?? const []) as List) - .map<Album>((j) => Album.fromJson(j)) + .map<Album>((entry) => Album.fromJson(entry)) .toList(), ); List<Artist> _parseArtists(dynamic json) => _artistProvider.syncWithVault( ((json ?? const []) as List) - .map<Artist>((j) => Artist.fromJson(j)) + .map<Artist>((entry) => Artist.fromJson(entry)) .toList(), );🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@lib/providers/overview_provider.dart` around lines 82 - 100, Rename the lambda parameter j to a descriptive JSON-entry name in both _parseAlbums and _parseArtists, updating the corresponding Album.fromJson and Artist.fromJson arguments while preserving behavior.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@lib/providers/overview_provider.dart`:
- Around line 82-100: Rename the lambda parameter j to a descriptive JSON-entry
name in both _parseAlbums and _parseArtists, updating the corresponding
Album.fromJson and Artist.fromJson arguments while preserving behavior.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: df04f6f8-273b-4694-a51f-a4f430c07c11
📒 Files selected for processing (3)
lib/providers/overview_provider.dartlib/ui/screens/home.darttest/providers/overview_provider_test.dart
koel web lets users reorder their home blocks and persists it as the home_blocks_order preference (returned via GET me). Parse it into the User model and order the Home screen blocks accordingly, falling back to koel web's default order when no preference is saved or the server (older API) doesn't expose one.
There was a problem hiding this comment.
🧹 Nitpick comments (1)
lib/ui/screens/home.dart (1)
42-47: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueSort comparator parameters should use descriptive names.
Per the project's coding guidelines, single-letter variable names are only allowed for
i,j(loop counters) andh(test harness). The sort lambda'saandbshould be renamed to descriptive names.As per coding guidelines:
**/*.{dart,ts,tsx,js,jsx,kt,swift}: Don't use single-letter variable names except for:iandjfor loop counters, andhfor the test harness. For all other cases (callback params, destructured fields, lambda args, etc.), pick a descriptive name that says what it is.♻️ Optional rename for sort comparator parameters
- indexed.sort((a, b) => sortKey(a).compareTo(sortKey(b))); + indexed.sort((left, right) => sortKey(left).compareTo(sortKey(right)));🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@lib/ui/screens/home.dart` around lines 42 - 47, Rename the sort comparator parameters in the indexed.sort callback to descriptive names representing the compared entries, and update their references in sortKey calls; leave the sorting behavior unchanged.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@lib/ui/screens/home.dart`:
- Around line 42-47: Rename the sort comparator parameters in the indexed.sort
callback to descriptive names representing the compared entries, and update
their references in sortKey calls; leave the sorting behavior unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: b929ddb0-67fb-4861-9bd0-a4eb1b204844
📒 Files selected for processing (5)
lib/models/user.dartlib/providers/auth_provider.dartlib/ui/screens/home.darttest/models/user_test.darttest/ui/screens/home_block_order_test.dart
The same album or artist can now appear in several Home blocks, which produced multiple heroes sharing one tag and crashed the details transition. Give AlbumCard/ArtistCard an asHero flag and let the Home screen grant the hero to only the first card per entity id; later duplicates render without a hero but still navigate.
Address review: use descriptive names for the JSON-entry map lambdas and the sort comparator params, per the project's no-single-letter-vars rule.
1 participant
koel's overview API (
FetchOverviewController) now returns more than most-played/top-albums/top-artists. This surfaces the rest on the Home screen.New sections rendered
Latest Albums, You Might Also Like (similar songs), New Songs, New Artists, Hidden Gems (least played), Random Songs, Random Albums, Random Artists — alongside the existing Recently Played, Most Played, Top Albums, Top Artists.
Block order
Defaults to koel web's default home layout. If the user has reordered their blocks on the web, that preference (
home_blocks_order, returned viaGET me) is honoured: saved blocks come first in the saved order, the rest keep the default order. The mobile app keeps the Recently Played section pinned at the top (it's a distinct list, not a card scroller), so its position in the saved order is ignored.Backward compatibility
Older API versions return neither the new overview keys nor the preference.
OverviewProviderparses each section with a null-safe fallback (json ?? const []), the Home screen only renders a block when its list is non-empty, and an empty/absenthome_blocks_orderfalls back to the default order. So on an older server nothing new appears and ordering is unchanged.Notes
_songBlock/_albumBlock/_artistBlockhelpers to avoid duplicating card-scroller boilerplate across 11 blocks.Tests
overview_provider_test.dart— every section populates from a full response; omitted keys (older API) stay empty;isEmptyis true for{}.home_block_order_test.dart— default order with no preference; saved blocks move to front; unknown saved ids ignored; unsaved blocks keep default order.user_test.dart—home_blocks_orderparsed from preferences; defaults to empty when absent; non-string entries dropped.Summary by CodeRabbit
asHerooption to album/artist cards to control Hero animation behavior.