Skip to content

Update docker-compose.postgres.yml #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tontonjo wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update docker-compose.postgres.yml #223

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker-compose.postgres.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ services:
- DB_DATABASE=koel
volumes:
- music:/music
- image_storage:/var/www/html/storage/app/public/images
- image_storage:/var/www/html/public/storage/images

@coderabbitai coderabbitai Bot Jun 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Mount path on Line 17 breaks the container’s declared image-storage contract.

image_storage is now mounted at /var/www/html/public/storage/images, but the image builds, permissions, docs, and changelog all target /var/www/html/storage/app/public/images. This can cause writes/persistence to miss the intended volume path and reintroduce read/write failures.

Suggested fix 
-      - image_storage:/var/www/html/public/storage/images
+      - image_storage:/var/www/html/storage/app/public/images

As per coding guidelines, align compose mountpoints with upstream container contracts documented in README.md:112-118, Dockerfile:82-112, and CHANGELOG.md:8-13.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- image_storage:/var/www/html/public/storage/images
- image_storage:/var/www/html/storage/app/public/images
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@docker-compose.postgres.yml` at line 17, The docker-compose service currently
mounts the volume image_storage to /var/www/html/public/storage/images which
breaks the container's expected storage contract; change the mount target for
the image_storage volume to /var/www/html/storage/app/public/images so it
matches the container's Dockerfile/README/CHANGELOG contract and ensures writes
persist to the correct path.

- search_index:/var/www/html/storage/search-indexes

database:
Expand Down