chore(ci): consolidate commitlint into ci.yaml and share setup composite#125
Merged
Conversation
Move the commitlint job into ci.yaml as a parallel job (pull_request only) and delete the standalone commitlint.yaml workflow. Add an `install` input to the setup composite action so jobs that only need mise-provided binaries (e.g. actionlint) can skip `pnpm install`. Switch the actionlint workflow to reuse the setup composite with `install: false` instead of calling jdx/mise-action directly. The `paths: ['.github/**']` filter is preserved on actionlint.yaml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
commitlint.yamlworkflow intoci.yamlas a parallelcommitlintjob (gated ongithub.event_name == 'pull_request').installinput (default'true') to thesetupcomposite action. When set to'false', the pnpm store cache andpnpm i --frozen-lockfilesteps are skipped, so jobs that only need mise-provided binaries can reuse the composite.actionlintworkflow to call./.github/actions/setupwithinstall: 'false'instead of invokingjdx/mise-actiondirectly. Thepaths: ['.github/**']filter is preserved, soactionlint.yamlstays as a separate workflow.Motivation: ravelact static analysis surfaced that three PR-triggered workflows share
checkout+setupboilerplate. Pullingcommitlintintoci.yamlremoves one duplicate trigger surface, and the newinstallflag letsactionlintreuse the same composite without forcing an unnecessarypnpm install.References