chore: add audience to --resource-type flag options#803
Merged
thomaswhyyou merged 1 commit intoJun 5, 2026
Merged
Conversation
thomaswhyyou
changed the title
thomaswhyyou
commented
Jun 4, 2026
| "translation", | ||
| "workflow", | ||
| ], | ||
| options: ALL_RESOURCE_TYPES, |
Contributor
Author
There was a problem hiding this comment.
ALL_RESOURCE_TYPES includes the "audience" type.
Contributor
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 66ecbdb. Configure here.
thomaswhyyou
force-pushed
the
thomas-kno-13272-cli-add-audience-to-resource-type-flag-options
branch
from
66ecbdb to
d2d40df
Compare
cjbell
approved these changes
Jun 4, 2026
thomaswhyyou
force-pushed
the
thomas-kno-13272-cli-add-audience-to-resource-type-flag-options
branch
from
d2d40df to
fb3ea50
Compare
thomaswhyyou
deleted the
thomas-kno-13272-cli-add-audience-to-resource-type-flag-options
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Accept "audience" for --resource-type flag in the commit index and commit list commands.
It is already accepted in the backend: https://github.com/knocklabs/control/blob/373f869d90038743de6f83757726ac9562652e7a/backend/lib/control/marshal/schemas/commit/commit_schema.ex#L10-L18