feat(KNO-13529): Docs for Knock hosted preference center (w/o custom domains)#1474
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
79b2b1d to
245b33e
Compare
245b33e to
aafe2de
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit aafe2de. Configure here.
There was a problem hiding this comment.
Stale comment
Risk MEDIUM: Adds new documentation page for Knock's hosted preference center with sidebar navigation changes and updates to the existing preferences overview page.
Reasons
- A new MDX page was added (
content/preferences/hosted-preference-center.mdxwith 137 lines), which triggers MEDIUM per the new-page rule.- The sidebar navigation file
data/sidebars/platformSidebar.tswas modified to include the new page entry, which triggers MEDIUM per the sidebar-change rule.- The diff is content-focused with no component, layout, style, or build configuration changes, so no HIGH triggers apply.
- All changes are scoped to a single documentation section (
content/preferences/), so cross-section risk does not apply.- Total diff is 158 additions and 2 deletions across 3 files — moderate scope with no destructive changes.
Notes
- Verify the new sidebar entry renders correctly and the page appears in the expected position under the Preferences section (between "Overview" and "Object preferences").
- Confirm all internal links in the new page resolve correctly, especially
/preferences/overview#how-preferences-work,/preferences/overview#preference-evaluation-rules,/preferences/overview#merging-preferences,/preferences/commercial-unsubscribe,/template-editor/branding,/integrations/email/layouts, and/preferences/overview#build-your-preference-center.- Check that the Callout components render properly with their JSX
textprops containing inline<a>and<code>elements.- Bugbot flagged 1 potential issue in its review — worth checking that finding before merge.
Sent by Cursor Automation: Docs PR classifier
cellomatt
left a comment
There was a problem hiding this comment.
First pass of feedback, I think it will be in a good spot with these changes but also pending some additions like custom domains and potentially a token-minting endpoint (not sure those are for initial launch).
Co-authored-by: Matt Kufchak <[email protected]>
3832dc6 to
1cb3c47
Compare
There was a problem hiding this comment.
Risk MEDIUM: Adds a new documentation page for Knock's hosted preference center, updates the existing preferences overview to reference it, and adds a sidebar navigation entry.
Reasons
- A new MDX page was added (
content/preferences/hosted-preference-center.mdx, 126 lines), triggering the new-page rule. - The sidebar navigation file
data/sidebars/platformSidebar.tswas modified to include the new entry, triggering the sidebar-change rule. - No HIGH-risk triggers apply: no components, layouts, lib, or styles
.ts/.tsxfiles were modified, and no build config or dependency changes are present. - All changes are scoped to a single documentation section (
content/preferences/), so cross-section risk does not apply. - A MEMBER reviewer (
cellomatt) has requested changes with 19 inline suggestions — the PR is not yet in a mergeable state.
Notes
- The PR has extensive review feedback from
cellomattwith specific copy and structural suggestions that still need to be addressed before merge. - Verify internal links resolve correctly after the requested changes are applied, especially
/preferences/overview#build-your-preference-center,/preferences/commercial-unsubscribe,/template-editor/branding, and/integrations/email/layouts. - Confirm the new sidebar entry appears in the correct position (between "Overview" and "Object preferences") once deployed.
- Bugbot flagged a low-severity issue about missing concept links for
objectsandtenantson first mention — worth addressing alongside the other review feedback.
Sent by Cursor Automation: Docs PR classifier
cellomatt
left a comment
There was a problem hiding this comment.
A couple more tiny things but otherwise looks good to me
Co-authored-by: Matt Kufchak <[email protected]>
Co-authored-by: Matt Kufchak <[email protected]>
Point per-tenant preferences to /preferences/tenant-preferences (the prior /multi-tenancy/per-tenant-preferences route 404s), link tenants to /multi-tenancy/overview directly, and use "enable" in the page description.




Uh oh!
There was an error while loading. Please reload this page.