Skip to content

feat(KNO-13529): Docs for Knock hosted preference center (w/o custom domains)#1474

Merged
andy-knock merged 6 commits into
mainfrom
knock-hosted-preference-center
Jun 9, 2026
Merged

feat(KNO-13529): Docs for Knock hosted preference center (w/o custom domains)#1474
andy-knock merged 6 commits into
mainfrom
knock-hosted-preference-center

Conversation

@andy-knock

@andy-knock andy-knock commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Screenshot 2026-06-04 at 3.36.42 PM.pngScreenshot 2026-06-04 at 3.36.37 PM.png

@vercel

vercel Bot commented Jun 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment Jun 9, 2026 2:45pm

Request Review

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Comment thread content/preferences/hosted-preference-center.mdx Outdated
Comment thread content/preferences/hosted-preference-center.mdx Outdated
Comment thread content/preferences/overview.mdx Outdated

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit aafe2de. Configure here.

Comment thread content/preferences/hosted-preference-center.mdx Outdated
@andy-knock andy-knock requested a review from cellomatt June 4, 2026 19:37
@andy-knock andy-knock changed the title feat() Docs for Knock hosted preference center (w/o custom domains) feat(KNO-13529): Docs for Knock hosted preference center (w/o custom domains) Jun 4, 2026
@andy-knock andy-knock marked this pull request as ready for review June 4, 2026 20:25
@linear-code

linear-code Bot commented Jun 4, 2026

Copy link
Copy Markdown

KNO-13529

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment

Risk MEDIUM: Adds new documentation page for Knock's hosted preference center with sidebar navigation changes and updates to the existing preferences overview page.

Reasons

  • A new MDX page was added (content/preferences/hosted-preference-center.mdx with 137 lines), which triggers MEDIUM per the new-page rule.
  • The sidebar navigation file data/sidebars/platformSidebar.ts was modified to include the new page entry, which triggers MEDIUM per the sidebar-change rule.
  • The diff is content-focused with no component, layout, style, or build configuration changes, so no HIGH triggers apply.
  • All changes are scoped to a single documentation section (content/preferences/), so cross-section risk does not apply.
  • Total diff is 158 additions and 2 deletions across 3 files — moderate scope with no destructive changes.

Notes

  • Verify the new sidebar entry renders correctly and the page appears in the expected position under the Preferences section (between "Overview" and "Object preferences").
  • Confirm all internal links in the new page resolve correctly, especially /preferences/overview#how-preferences-work, /preferences/overview#preference-evaluation-rules, /preferences/overview#merging-preferences, /preferences/commercial-unsubscribe, /template-editor/branding, /integrations/email/layouts, and /preferences/overview#build-your-preference-center.
  • Check that the Callout components render properly with their JSX text props containing inline <a> and <code> elements.
  • Bugbot flagged 1 potential issue in its review — worth checking that finding before merge.
Open in Web View Automation 

Sent by Cursor Automation: Docs PR classifier

@cellomatt cellomatt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass of feedback, I think it will be in a good spot with these changes but also pending some additions like custom domains and potentially a token-minting endpoint (not sure those are for initial launch).

Comment thread content/preferences/hosted-preference-center.mdx Outdated
Comment thread content/preferences/hosted-preference-center.mdx Outdated
Comment thread content/preferences/hosted-preference-center.mdx Outdated
Comment thread content/preferences/hosted-preference-center.mdx Outdated
Comment thread content/preferences/hosted-preference-center.mdx Outdated
Comment thread content/preferences/hosted-preference-center.mdx Outdated
Comment thread content/preferences/hosted-preference-center.mdx Outdated
Comment thread content/preferences/hosted-preference-center.mdx Outdated
Comment thread content/preferences/hosted-preference-center.mdx Outdated
Comment thread content/preferences/overview.mdx Outdated
@andy-knock andy-knock marked this pull request as draft June 8, 2026 18:42
@andy-knock andy-knock force-pushed the knock-hosted-preference-center branch from 3832dc6 to 1cb3c47 Compare June 8, 2026 18:53
@andy-knock andy-knock marked this pull request as ready for review June 8, 2026 18:54

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk MEDIUM: Adds a new documentation page for Knock's hosted preference center, updates the existing preferences overview to reference it, and adds a sidebar navigation entry.

Reasons

  • A new MDX page was added (content/preferences/hosted-preference-center.mdx, 126 lines), triggering the new-page rule.
  • The sidebar navigation file data/sidebars/platformSidebar.ts was modified to include the new entry, triggering the sidebar-change rule.
  • No HIGH-risk triggers apply: no components, layouts, lib, or styles .ts/.tsx files were modified, and no build config or dependency changes are present.
  • All changes are scoped to a single documentation section (content/preferences/), so cross-section risk does not apply.
  • A MEMBER reviewer (cellomatt) has requested changes with 19 inline suggestions — the PR is not yet in a mergeable state.

Notes

  • The PR has extensive review feedback from cellomatt with specific copy and structural suggestions that still need to be addressed before merge.
  • Verify internal links resolve correctly after the requested changes are applied, especially /preferences/overview#build-your-preference-center, /preferences/commercial-unsubscribe, /template-editor/branding, and /integrations/email/layouts.
  • Confirm the new sidebar entry appears in the correct position (between "Overview" and "Object preferences") once deployed.
  • Bugbot flagged a low-severity issue about missing concept links for objects and tenants on first mention — worth addressing alongside the other review feedback.
Open in Web View Automation 

Sent by Cursor Automation: Docs PR classifier

@cellomatt cellomatt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more tiny things but otherwise looks good to me

Comment thread content/preferences/hosted-preference-center.mdx Outdated
Comment thread content/preferences/hosted-preference-center.mdx Outdated
Point per-tenant preferences to /preferences/tenant-preferences (the
prior /multi-tenancy/per-tenant-preferences route 404s), link tenants to
/multi-tenancy/overview directly, and use "enable" in the page description.
@andy-knock andy-knock merged commit e9f5cf0 into main Jun 9, 2026
5 of 6 checks passed
@andy-knock andy-knock deleted the knock-hosted-preference-center branch June 9, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants