Skip to content

Fix incorrect buffer batching in multiblock preview rendering on 1.21.1 #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kawaiixissa13 wants to merge 2 commits into
base: version/1.21.1
Choose a base branch
from
+3 −1
Open

Fix incorrect buffer batching in multiblock preview rendering on 1.21.1 #376

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40b45ef
Fix incorrect buffer batching in multiblock preview rendering on 1.21.1
kawaiixissa13 Jul 16, 2026
dbb4316
Fix indentation
kawaiixissa13 Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion common/src/main/java/com/klikli_dev/modonomicon/client/render/MultiblockPreviewRenderer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,8 +250,10 @@ public static void renderMultiblock(Level level, PoseStack ms) {
ms.pushPose();
ms.translate(-renderPosX, -renderPosY, -renderPosZ);

var mainBuffers = mc.renderBuffers().bufferSource();
mainBuffers.endBatch(); // when we do initBuffers we keep the buffers but dont know if were still batching, so it doesnt properly end in the getBuffer call and breaks stuff
if (buffers == null) {
buffers = initBuffers(mc.renderBuffers().bufferSource());
buffers = initBuffers(mainBuffers);
}

BlockPos checkPos = null;
Expand Down