feat: mp-2855-goal copy updates#6986
Conversation
dyersituations
left a comment
There was a problem hiding this comment.
See comment about style differences.
|
Hey @dyersituations |
@infante-jaime thanks for the update. With the demo coming up, I'll test this after. Post a comment when your testing is done, and I'll take a look later this morning. |
|
Done |
dyersituations
left a comment
There was a problem hiding this comment.
@infante-jaime I can't functionally test at the moment due to the dev DB being refreshed, but here are a couple questions.
| import RecommendLoanForGoalContent from '#src/components/LoanCards/RecommendLoanForGoal/RecommendLoanForGoalContent'; | ||
| import RecommendLoanForGoalFooter from '#src/components/LoanCards/RecommendLoanForGoal/RecommendLoanForGoalFooter'; | ||
| import RecommendLoanForGoalHeader from '#src/components/LoanCards/RecommendLoanForGoal/RecommendLoanForGoalHeader'; | ||
| import HandsPlant from '#src/assets/images/thanks-page/hands-plant.gif'; |
There was a problem hiding this comment.
Can this old image be removed?
| && !goalSignupThanksViewCapped.value | ||
| && !goalSignupThanksViewCounted.value) { | ||
| incrementGoalSignupThanksViewCount(cookieStore); | ||
| goalSignupThanksViewCounted.value = true; |
There was a problem hiding this comment.
Why was this line change needed?
There was a problem hiding this comment.
good catch indeed it was not needed, removed

MP-2855
Summary
Updates the annual goal signup copy and entrypoints for MP-2855.
This PR:
Copy Scenarios
Notes
mykiva_goals_row; it keeps its existing no-current-year-goal gate.kv_goal_signup_thanks_views.?goalSignupDate=YYYY-MM-DD.