Skip to content

fix(kv-components): update logged imenu, centralize search suggestion…#834

Merged
mcstover merged 1 commit into
mainfrom
fix-cit-KvWwwHeaderBasic-improvements
Jun 10, 2026
Merged

fix(kv-components): update logged imenu, centralize search suggestion…#834
mcstover merged 1 commit into
mainfrom
fix-cit-KvWwwHeaderBasic-improvements

Conversation

@mcstover

Copy link
Copy Markdown
Collaborator

This pull request updates the KvWwwHeaderBasic Vue component and related files to improve how search suggestions are loaded for the header's search bar and to enhance the "MyKiva" menu with more dynamic links for borrowers and trustees. The changes make the header more flexible and future-proof, allowing hosts to fetch search suggestions on demand and enabling richer navigation for special user roles.

Header Search Bar Improvements:

  • Added a new loadSearchSuggestions method to KvWwwHeaderBasic.vue that fetches loan search suggestions via Apollo GraphQL on demand, using a new query (LOAN_SEARCH_SUGGESTIONS_QUERY). The component now prefers these fetched suggestions but falls back to the prop if needed. [1] [2] [3] [4] [5] [6]
  • The appOrigin prop is now resolved at runtime if not provided, ensuring correct navigation URLs in all environments. [1] [2] [3] [4] [5]
  • Updated the SearchBar.vue and useTypeaheadSearch.ts utility to support a reactive appOrigin and to use the new search suggestion loading logic. [1] [2]

MyKiva Menu Enhancements:

  • Expanded the "MyKiva" menu to show additional, context-aware links for borrowers and trustees, including direct links to the user's borrower dashboard, loan page, conversations, trustee loans, and trustee public page. These use new props: trusteeId and mostRecentBorrowedLoanId. [1] [2] [3] [4]
  • Updated the menu logic to compute trustee loan URLs dynamically and to track menu link clicks for analytics. [1] [2]

Storybook and Testing Support:

  • Enhanced Storybook stories to support new props and to simulate fetching search suggestions via Apollo, ensuring the new dynamic loading flow is testable in stories. [1] [2] [3] [4]

Styling and Minor Adjustments:

  • Removed the bottom border from the main nav in KvWwwHeaderBasic.vue so hosts can control border styling.
  • Adjusted menu link padding for improved visual consistency.

These changes make the header component more robust, easier to integrate into different host environments, and more useful for users with special roles.… query, minor fixes

@mcstover mcstover requested review from a team and eddieferrer June 10, 2026 17:01
@mcstover mcstover merged commit c1fa118 into main Jun 10, 2026
5 checks passed
@mcstover mcstover deleted the fix-cit-KvWwwHeaderBasic-improvements branch June 10, 2026 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants