Skip to content

Introduce camera - #17

Merged
kimkulling merged 1 commit into
mainfrom
feature/introduce_scene
Jul 24, 2026
Merged

Introduce camera#17
kimkulling merged 1 commit into
mainfrom
feature/introduce_scene

Conversation

@kimkulling

@kimkulling kimkulling commented Jul 24, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • New Features
    • Added camera support with configurable perspective and orthographic projection modes.
    • Added camera controls for positioning, aiming, and yaw, pitch, and roll rotation.
    • Camera view matrices are updated automatically based on camera orientation and position.

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 707a5e9c-a72e-48ed-a21f-1d5493c0478d

📥 Commits

Reviewing files that changed from the base of the PR and between b180b33 and bb4710e.

📒 Files selected for processing (2)
  • src/runtime/CMakeLists.txt
  • src/runtime/scene/camera.h

Walkthrough

Adds a public GLM-based Camera class with projection state and view-matrix operations, then registers its header in the runtime shared library. The declared and defined lookAt signatures do not match.

Changes

Camera runtime integration

Layer / File(s) Summary
Camera type and view updates
src/runtime/scene/camera.h
Defines camera state, projection modes, constructor behavior, and inline GLM-based yaw, pitch, roll, and look-at view-matrix updates.
Runtime source registration
src/runtime/CMakeLists.txt
Adds scene/camera.h to the runtime source list and segfault_runtime target.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: kullingk

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/introduce_scene

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kimkulling
kimkulling merged commit df61e68 into main Jul 24, 2026
2 of 3 checks passed
@kimkulling
kimkulling deleted the feature/introduce_scene branch July 24, 2026 12:06
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants