Use the plural form appropriate to the message, not the requested locale#34
Open
benjaminwinger wants to merge 1 commit into
Open
Use the plural form appropriate to the message, not the requested locale#34benjaminwinger wants to merge 1 commit into
benjaminwinger wants to merge 1 commit into
Conversation
If the message isn't available and the fallback is used, it would otherwise use the plural function for the requested locale, not the fallbackLocale
98bf46e to
cd9693b
Compare
flexiondotorg
added a commit
to Oval-Tutu/smiti18n
that referenced
this pull request
Jan 12, 2025
If the message isn't available and the fallback is used, it would otherwise use the plural function for the requested locale, not the fallbackLocale - Pass locale through pluralization chain - Separate custom and default pluralization handling - Improve pluralization accuracy for mixed-locale usage - Add tests for Polish locale pluralization Cherry-picked from kikito/i18n.lua#34
flexiondotorg
added a commit
to Oval-Tutu/smiti18n
that referenced
this pull request
Jan 12, 2025
If the message isn't available and the fallback is used, it would otherwise use the plural function for the requested locale, not the fallbackLocale - Pass locale through pluralization chain - Separate custom and default pluralization handling - Improve pluralization accuracy for mixed-locale usage - Add tests for Polish locale pluralization Cherry-picked from kikito/i18n.lua#34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the message isn't available and the fallback is used, it would otherwise use the plural function for the requested locale, not the fallbackLocale.
This bug causes incorrect output, or even crashes if the requested locale and the fallback locale are different enough.
E.g.