Allow locale to be a list#32
Open
benjaminwinger wants to merge 1 commit into
Open
Conversation
3a34e20 to
5a41912
Compare
This allows an arbitrary-length of fallback chain for the user-requested locale.
5a41912 to
3450802
Compare
Author
|
Updated to include tests. Note that I removed the following test, as there doesn't seem to be a meaningful result for it with arbitrary length fallback chains, and I'm not sure that it's necessary in the first place ( it("returns the fallbackLocale ancestry if locale is parent of fallbackLocale", function()
assert.same(variants.fallbacks('en','en-US'), {'en-US', 'en'})
end) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows an arbitrary-length of fallback chain for the user-requested locale, letting users provide multiple preferred languages instead of just one.