Added support for arrays of strings to i18n. Arrays support pluralisa…#30
Open
personalnadir wants to merge 3 commits into
Open
Added support for arrays of strings to i18n. Arrays support pluralisa…#30personalnadir wants to merge 3 commits into
personalnadir wants to merge 3 commits into
Conversation
…tion and iterpolation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this is my attempt to add support for #29
I've changed the way pluralisation works to support this. Whereas previously the code always used data.count to determine the pluralisation it now uses the first
%{field}or%<value>name in the string, falling back to count if none found.This will cause issues if the user attempts to combine pluralisation and interpolation with independent variables at the same time. At the moment I cannot think of a use case for this.