feat: improve Redis pub/sub listener resilience with reconnect logic … - #132
Merged
Conversation
…and graceful teardown
The listener now runs an unbounded reconnect loop and drains messages via `get_message` instead of `listen()`. The existing test awaited the listener to completion and only stubbed `listen()`, so against the new code `get_message` raised AttributeError, the reconnect loop caught it and looped forever — hanging CI on this test. Drive the listener as a cancellable task (as the lifespan does), stub `get_message` to deliver one message then report idle, and cancel once the message is bridged. Co-Authored-By: Claude Opus 4.8 <[email protected]>
khashashin
added a commit
that referenced
this pull request
Jun 14, 2026
#132) * feat: improve Redis pub/sub listener resilience with reconnect logic and graceful teardown * test: fix redis pub/sub listener test hanging on reconnect loop The listener now runs an unbounded reconnect loop and drains messages via `get_message` instead of `listen()`. The existing test awaited the listener to completion and only stubbed `listen()`, so against the new code `get_message` raised AttributeError, the reconnect loop caught it and looped forever — hanging CI on this test. Drive the listener as a cancellable task (as the lifespan does), stub `get_message` to deliver one message then report idle, and cancel once the message is bridged. Co-Authored-By: Claude Opus 4.8 <[email protected]> --------- Co-authored-by: Claude Opus 4.8 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…and graceful teardown