Add data source LU1 (Luxembourg STATEC)#282
Closed
NXDinh wants to merge 3 commits into
Closed
Conversation
Registers the Luxembourg national statistical office (STATEC, platform
LUSTAT) as `LU1` — the server's real SDMX agency id, so a bare
`Client("LU1").dataflow()` works without an explicit agency argument.
- sources.json: entry with a `supports` block calibrated against the
live service (the resources it answers with 404/501).
- test_sources.py: TestLU1 — `endpoint_args` for the data endpoint and
`xfail` for metadata/registration (not in SDMX-REST v2.1).
- whatsnew.rst: changelog entry.
DataSourceTest against the live service: 13 endpoints pass, 21 xfail,
0 failures.
Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
A live re-probe of LUSTAT showed two endpoints in the initial LU1 entry were miscategorised relative to the source-policy documented in doc/sources.rst: - organisationscheme returns HTTP 400 Bad Request - structure returns HTTP 501 Not Implemented `supports: false` is reserved for HTTP 404; 400/501 endpoints belong in the test class `xfail` mapping (as in TestUY110). - sources.json: LU1 `supports` now lists only the five 404 endpoints. - test_sources.py: TestLU1 `xfail` adds organisationscheme (HTTPError) and structure (NotImplementedError). - sources.rst: add the LU1 source section. - whatsnew.rst: use the `:ref:` role for the LU1 entry. DataSourceTest: 13 passed, 21 xfailed, 0 failed. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a new SDMX data source entry for Luxembourg STATEC (LUSTAT) and wires it into docs and the data-source test suite.
Changes:
- Add
LU1tosdmx/sources.jsonwith base URL and declared capabilities. - Add
TestLU1to exercise LU1 endpoints and mark known unsupported/failing endpoints as xfail. - Document the new source in
doc/sources.rstand mention it indoc/whatsnew.rst.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| sdmx/tests/test_sources.py | Adds a new DataSourceTest subclass for LU1 and documents expected failures. |
| sdmx/sources.json | Registers the LU1 source ID, name, URL, and advertised “supports” matrix. |
| doc/whatsnew.rst | Adds LU1 to the “Next release” notes. |
| doc/sources.rst | Adds a new LU1 reference section for the docs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+346
to
+355
| "id": "LU1", | ||
| "name": "Luxembourg STATEC", | ||
| "url": "https://lustat.statec.lu/rest", | ||
| "supports": { | ||
| "agencyscheme": false, | ||
| "dataconsumerscheme": false, | ||
| "metadataflow": false, | ||
| "metadatastructure": false, | ||
| "structureset": false | ||
| } |
|
|
||
| .. _LU1: | ||
|
|
||
| ``LU1``: STATEC (Luxembourg) |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the Luxembourg national statistical office — STATEC, dissemination platform LUSTAT — as data source
LU1.LU1LU1is the service's own SDMX agency id, so a bareClient("LU1").dataflow()resolves without an explicitagency_idargument.Changes
sdmx/sources.json— newLU1entry. Thesupportsblock disables the five structural endpoints the service answers with HTTP 404 (agencyscheme,dataconsumerscheme,metadataflow,metadatastructure,structureset).sdmx/tests/test_sources.py—TestLU1(DataSourceTest)withendpoint_argsfor thedataendpoint and anxfailmapping for the endpoints that return 400 (organisationscheme→HTTPError) or 501 (structure→NotImplementedError), alongside the usual sdmx-internalmetadata/registrationentries. This mirrorsTestUY110.doc/sources.rst—LU1source section.doc/whatsnew.rst— changelog entry.The 404-vs-400/501 split follows the policy under "Handling and testing limitations and (un)supported endpoints" in
doc/sources.rst: each endpoint was probed live to record its actual HTTP status.Verification
DataSourceTestagainst the live service —pytest -m source -k TestLU1 --sdmx-fetch-data:The
whatsnew.rstbullet uses the:ref:role; I'll add the:pull:reference in a follow-up commit once this PR is numbered.