improve clarity of upper case characters and code reuse#6
Conversation
a056018 to
d3fe16a
Compare
blake2573
left a comment
blake2573
left a comment
There was a problem hiding this comment.
It would be good to see this merged soon - I've been dealing with risky packages in production while waiting for this massive code reliability improvement to go through.
LGTM!
Samuel-BlankAmber
left a comment
Samuel-BlankAmber
left a comment
There was a problem hiding this comment.
Fantastic work. Love to see such a great addition being contributed to my favorite package(s). One minor point of feedback that could help increase widespread adoption and understanding of the project.
| export default "J"; | ||
| /** | ||
| * @link https://en.wikipedia.org/wiki/J | ||
| * I bet you didn't read through all of these |
There was a problem hiding this comment.
| * I bet you didn't read through all of these | |
| * I bet you did not read through all of these |
As this is in the documentation for the uppercase character J, I suspect many individuals reading this will not be familiar with advanced concepts such as Punctuation and Apostrophes. To ensure the documentation remains readable to beginners of the alphabet, I would encourage you to remove this use of an Apostrophe.
|
Hi, do we have an ETA on when this is getting merged? My team would greatly benefit from the superior DX provided by this PR and are eagerly awaiting its merge. Thanks. |
4 participants
Upper case letters can be derived from the lower case ones with only a minor runtime cost. Also added some helpful documentation for people unfamiliar with the concept of letters.
Context: https://twitter.com/bendmorris/status/1438369582125699072