auto-resolve sso provider icons via simple icons #8
+62
−84
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -198,55 +198,3 @@ export const SpinnerIcon = (p: IconProps) => ( | |
| /> | ||
| </svg> | ||
| ); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,40 +1,58 @@ | ||
| import { useState, type ReactNode } from "react"; | ||
| import { BuildingIcon, KeyIcon } from "./icons"; | ||
|
|
||
| export interface SSOProviderInfo { | ||
| label: string; | ||
| icon: ReactNode; | ||
| } | ||
|
|
||
| const NON_BRAND_ICONS: Record<string, { label: string; icon: ReactNode }> = { | ||
| passkey: { label: "Passkey", icon: <KeyIcon className="kma-sso-icon" /> }, | ||
| sso: { label: "SSO", icon: <BuildingIcon className="kma-sso-icon" /> }, | ||
| saml: { label: "SSO", icon: <BuildingIcon className="kma-sso-icon" /> }, | ||
| }; | ||
|
|
||
| function slugify(provider: string): string { | ||
| return provider.toLowerCase().replace(/[^a-z0-9]/g, ""); | ||
| } | ||
|
|
||
| function titleCase(provider: string): string { | ||
| return provider | ||
| .split(/[\s_-]+/) | ||
| .filter(Boolean) | ||
| .map((w) => w.charAt(0).toUpperCase() + w.slice(1).toLowerCase()) | ||
| .join(" "); | ||
| } | ||
|
|
||
| function SSOProviderIcon({ provider }: { provider: string }) { | ||
| const [errored, setErrored] = useState(false); | ||
| const slug = slugify(provider); | ||
| const letter = provider.trim().charAt(0).toUpperCase() || "?"; | ||
|
|
||
| if (!slug || errored) { | ||
| return ( | ||
| <span className="kma-sso-icon kma-sso-icon--letter" aria-hidden="true"> | ||
| {letter} | ||
| </span> | ||
| ); | ||
| } | ||
|
|
||
| return ( | ||
| <img | ||
| src={`https://cdn.simpleicons.org/${slug}`} | ||
| alt="" | ||
| className="kma-sso-icon" | ||
| onError={() => setErrored(true)} | ||
| /> | ||
| ); | ||
| } | ||
|
|
||
| export function getSSOProviderInfo(provider: string): SSOProviderInfo { | ||
| const key = slugify(provider); | ||
| const nonBrand = NON_BRAND_ICONS[key]; | ||
| if (nonBrand) return nonBrand; | ||
|
There was a problem hiding this comment. Non-brand providers lose substring matching, breaking compound namesMedium Severity The old code used Additional Locations (1)  Reviewed by Cursor Bugbot for commit 0c8c226. Configure here. |
||
| return { | ||
| label: titleCase(provider), | ||
| icon: <SSOProviderIcon provider={provider} />, | ||
| }; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stale error state persists across provider prop changes
Low Severity
SSOProviderIconstores CDN load failure inerroredstate viauseState, but never resets it when theproviderprop changes. If a CDN request fails for one provider and then the component receives a differentprovider(e.g.,ssoProviderchanges in the parent while the tree position stays mounted), the staleerrored = truecauses the new provider to immediately render the letter-avatar fallback instead of attempting its own CDN fetch.Reviewed by Cursor Bugbot for commit 0c8c226. Configure here.