add gitlab as an sso provider#7
Closed
masnwilliams wants to merge 2 commits into
Closed
Conversation
|
Firetiger deploy monitoring skipped This PR didn't match the auto-monitor filter configured on your GitHub connection:
Reason: PR modifies SSO provider UI components in managed-auth-react, not kernel API endpoints or Temporal workflows. To monitor this PR anyway, reply with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds GitLab to the list of recognized SSO providers in
getSSOProviderInfo, so any provider key containinggitlabrenders with the GitLab label and tanuki mark.GitLabMarkSVG icon inicons.tsx.gitlabinsso-provider.tsx.Test plan
bun run typecheckbun run --filter '@onkernel/managed-auth-react' buildgitlabprovider key renders the correct label and iconNote
Low Risk
Low risk UI-only change: adds a new SVG icon and a simple
gitlabstring match ingetSSOProviderInfo, with no auth flow or data-handling logic modified.Overview
Adds GitLab as a recognized SSO provider in
managed-auth-reactso provider keys containinggitlabrender with a GitLab label and the newGitLabMarkicon.Introduces the
GitLabMarkSVG inicons.tsxand wires it intogetSSOProviderInfoinsso-provider.tsx.Reviewed by Cursor Bugbot for commit b97599b. Bugbot is set up for automated code reviews on this repo. Configure here.