Fix Int32 overflow in SSE retry field - #771
Merged
Merged
Conversation
EventStream#send cast retry.total_milliseconds (Float64) with .to_i (Int32), so a retry span over ~24.8 days (Int32::MAX ms) raised OverflowError inside the streaming handler. Use .to_i64.
Member
Author
|
It's a simple patch for overflow prevention. and CI passed, so I'll self-merge it! |
Contributor
|
Maybe using |
Member
Author
|
Hi @Sija Thanks for the suggestion! Nothing guards against negative spans here, so Happy to add a guard in a follow-up PR that skips the field when it's negative. With that in place |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
EventStream#sendrendered the SSEretryfield with.to_i(Int32). A retry span longer than ~24.8 days (Int32::MAXmilliseconds) overflowed and raisedOverflowErrorinside the streaming handler, breaking the response. Switched to.to_i64.Bug case (before this PR)
Values within the normal range (seconds/minutes) are unaffected — the emitted bytes are identical.
Test
Added a regression spec asserting
retry: 60.daysrendersretry: 5184000000.