self-development: label kelos-image-update PRs#1200
Open
kelos-bot[bot] wants to merge 1 commit into
Open
Conversation
…-update Apply a dedicated `agent/kelos-image-update` label on both the create and edit paths so image-update PRs can be filtered apart from other `generated-by-kelos` PRs (workers, config-update, etc.).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/kind cleanup
What this PR does / why we need it:
Adds the new
agent/kelos-image-updatelabel to PRs created and updatedby the
kelos-image-updateTaskSpawner. The label is applied in boththe create path (
gh pr create) and the rolling-update path(
gh pr edit), so existing image-update PRs that were opened beforethe label existed also pick it up on the next refresh.
This makes image-update PRs filterable separately from other
generated-by-kelosPRs (workers, config-update, etc.), which allcurrently share the same broad label.
The
agent/kelos-image-updatelabel was created in the repo as partof this change.
Which issue(s) this PR is related to:
Fixes #1198
Special notes for your reviewer:
Only
self-development/kelos-image-update.yamlis modified.Does this PR introduce a user-facing change?
Summary by cubic
Apply a dedicated
agent/kelos-image-updatelabel to image-update PRs created and refreshed by thekelos-image-updateTaskSpawner. This lets us filter these PRs separately from othergenerated-by-kelositems and ensures older PRs pick up the label on their next refresh (addresses #1198).Written for commit be5a5e4. Summary will update on new commits. Review in cubic