refactor: simplify exclusive timeZone/utcOffset runtime check#1067
Open
Gdhanush-13 wants to merge 1 commit into
Open
refactor: simplify exclusive timeZone/utcOffset runtime check#1067Gdhanush-13 wants to merge 1 commit into
Gdhanush-13 wants to merge 1 commit into
Conversation
The original if-else-if-else chain for CronTime initialization had a redundant third branch. After the exclusive parameter check throws for JS users who pass both, at most one of timeZone or utcOffset can be non-null. The logic is simplified to a single ternary. Fixes kelektiv#704
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
CronTimeinitialization after the exclusive parameter check (#704) had a redundant thirdelsebranch:After the
ExclusiveParametersErrorthrow, bothtimeZoneandutcOffsetare guaranteed to not be non-null simultaneously. The thirdelsebranch is therefore always equivalent to theelse ifbranch (both passnull/undefined), making it redundant.Solution
Simplify to a ternary -
timeZone != nullis the only branch needed; the fallthrough handles all other cases:No behavior changes - existing tests pass unchanged.
Fixes #704