Add IfPredicate for more flexible interface filtering#474
Merged
Conversation
keepsimple1
reviewed
Jun 20, 2026
keepsimple1
left a comment
keepsimple1
left a comment
Owner
There was a problem hiding this comment.
Thanks for your PR! Overall it makes sense to me. A couple of comments inline, and can you please add a test?
MAlba124
force-pushed
the
custom-iface-filter
branch
from
9123c11 to
5166792
Compare
MAlba124
changed the title
IfPredicate for more flexible interface filtering
keepsimple1
approved these changes
Jun 20, 2026
keepsimple1
left a comment
keepsimple1
left a comment
Owner
There was a problem hiding this comment.
Looks good! A couple of new nitpicks inline. Thanks!
MAlba124
force-pushed
the
custom-iface-filter
branch
from
5166792 to
7523ce8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to disable interfaces based on a regex, this isn't possible with the current
IfKindAPI. Let me know if this feature is wanted and if the additional API is ok.