fix: restore removed test coverage alongside UTF-8 encoding changes#134
Open
knoal wants to merge 2 commits into
Open
fix: restore removed test coverage alongside UTF-8 encoding changes#134knoal wants to merge 2 commits into
knoal wants to merge 2 commits into
Conversation
Reverts three coverage regressions introduced alongside the UTF-8 encoding changes in PR kcolbchain#113: 1. Restored LAB_PAGES constant and MULTIPAGE_LAB / SIMULATOR paths 2. test_files_exist() now checks all 13 multipage lab files again 3. Restored test_simulator_links_to_multipage_lab() — simulator.html still exists 4. test_home_links_to_lab() checks both ./lab/index.html and ./agents-demo.html links (was reduced to only one link — restoring original dual-link check) The UTF-8 encoding changes from the original PR (encoding="utf-8" on read_text() calls and pytest.mark.skipif simplification for node) are preserved. All 35 tests pass (up from 34 in the original PR, due to restored coverage).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for PR #113 (Make web lab tests use explicit UTF-8 encoding):
The pipeline flagged
needs_humandue to three coverage regressions alongside the UTF-8 changes:Fixes:
Restored LAB_PAGES + MULTIPAGE_LAB/SIMULATOR constants — removed in the original PR but the files still exist in the repo.
test_files_exist() — now checks all 13 multipage lab files again (was reduced to only checking LAB and HOME).
test_simulator_links_to_multipage_lab() — fully restored (simulator.html still exists in web/).
test_home_links_to_lab() — restored to check both
./lab/index.htmlAND./agents-demo.htmllinks. The original PR dropped the multi-page lab link assertion.Preserved from original PR:
encoding="utf-8"fixes onread_text()callspytest.mark.skipif(shutil.which("node") is None)simplification for node checktest_js_has_no_syntax_errorsTest results: 35 passed (the original PR had 34 — restored coverage adds back 1 test).