feat: move Value to alloc feature#23
Open
XAMPPRocky wants to merge 1 commit into
Open
Conversation
Member
|
CI's failing, did you ... test this? |
Author
Yes it is working locally for me. I'll fix the CI errors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously Value was under the std feature flag, meaning it could not be used in no-std contexts. However this seems like an oversight from the previous crate because nothing in Value actually used std features and could be entirely under the alloc feature (as evidenced by the fact that this makes no code changes aside from adding some imports.