Handle invalid JSONPath in message preview filters - #1917
Handle invalid JSONPath in message preview filters#1917reachsrinivaschennupati-tech wants to merge 1 commit into
Conversation
|
AI Summary The GitHub issue addresses handling invalid JSONPath expressions in message preview filters, likely to prevent crashes or unexpected behavior when users provide malformed paths. The proposed solution involves adding validation or graceful error handling for such cases, though specific changes and testing details are not provided. The issue includes a checklist for code review and testing, but no breaking changes are mentioned. |
📝 WalkthroughWalkthroughMessage rendering now catches exceptions from invalid JSONPath filters and returns ChangesMessage filter resilience
Estimated code review effort: 1 (Trivial) | ~5 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| </div> | ||
| ); | ||
| } catch { | ||
| return null; |
There was a problem hiding this comment.
how's that gonna be treated at the ui?
|
@Haarolean I corrected the PR checklist formatting so the checklist linter can parse the checked items properly. Please review when you have a chance. |
What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)
Summary by CodeRabbit
Bug Fixes
Tests