Replace generate.sh with a regenerate-proxies CMake target - #27
Merged
Conversation
Move proxy generation into CMake (cmake/GenerateProxies.cmake): a
regenerate-proxies target runs the in-tree sdbus-c++-xml2cpp tool over the
interface->proxy map, then formats the output with the existing
scripts/clang-format.sh, exactly as generate.sh did.
The target is deliberately opt-in and NOT part of the default build. The proxy
headers are committed to the repo, and wiring generation into the build via
add_custom_command OUTPUTs would rewrite tracked source files on a normal build
(a fresh build makes the tool newer than the committed headers, so they would
regenerate). Regenerate explicitly instead:
cmake --build build --target regenerate-proxies
Verified: building the target reproduces the committed src/proxy/ byte-for-byte
(empty git diff), and a normal build leaves src/proxy/ untouched. The single
source of truth for the interface->proxy mapping now lives in the CMake module.
README and the new-service checklist updated; generate.sh removed.
Signed-off-by: Joel Winarske <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace generate.sh with a regenerate-proxies CMake target
Move proxy generation into CMake (cmake/GenerateProxies.cmake): a
regenerate-proxies target runs the in-tree sdbus-c++-xml2cpp tool over the
interface->proxy map, then formats the output with the existing
scripts/clang-format.sh, exactly as generate.sh did.
The target is deliberately opt-in and NOT part of the default build. The proxy
headers are committed to the repo, and wiring generation into the build via
add_custom_command OUTPUTs would rewrite tracked source files on a normal build (a fresh build makes the tool newer than the committed headers, so they would regenerate). Regenerate explicitly instead:
Verified: building the target reproduces the committed src/proxy/ byte-for-byte (empty git diff), and a normal build leaves src/proxy/ untouched. The single source of truth for the interface->proxy mapping now lives in the CMake module. README and the new-service checklist updated; generate.sh removed.