Install sdbus-cpp system dependencies in the publish job - #9
Merged
Conversation
The publish workflow installed nothing, so `dart test` failed while the
build hook configured third_party/sdbus-cpp:
Package 'libsystemd', required by 'virtual:world', not found
Error: Running build hooks failed.
The job exited before reaching either the dry run or the publish step.
Install the same dependencies ci.yml uses to drive CMake.
Signed-off-by: Joel Winarske <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
v0.3.0andv0.2.0publish runs both failed. Neither reached thepublish step:
publish.ymlinstalls no system packages, sodart testfails while thebuild hook configures
third_party/sdbus-cpp.ci.ymlinstallscmake ninja-build clang-19 libsystemd-dev libgtest-dev, which is why CIpasses on the same commit.
This adds the subset the build hook needs:
cmake,ninja-build,pkg-config,libsystemd-dev. The C++ test dependencies are not requiredhere because the hook builds only the shared library.
Once this is on
main,v0.3.0needs to be recreated so the tagged commitcontains the fixed workflow — a tag push runs the workflow as it exists at
that tag.
Whether publishing then succeeds is still unverified:
bluez_nativeis noton pub.dev, and automated publishing is configured per package on its pub.dev
admin page, which requires the package to exist. That may require a one-time
manual publish. The dependency failure masked this, so it has never actually
been exercised.