Release 0.3.0 - #8
Merged
Merged
Conversation
The LICENSE file named the Apache License 2.0 but did not reproduce it. Three sentences of the operative text were reworded and the appendix was absent, so the file did not match the license it claimed and license scanners could not identify it. Replace it with the verbatim text. Add example/README.md describing what each example does and how to run it. Signed-off-by: Joel Winarske <[email protected]>
Raise the hooks constraint to ^2.1.0, shorten the package description to the length search engines display, and drop the documentation URL, which pointed at a page that does not exist. Signed-off-by: Joel Winarske <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepares 0.3.0 and corrects two packaging problems found while checking
release readiness.
LICENSE did not reproduce the license it named
The file was headed "Apache License 2.0" but three sentences of the operative
text had been reworded and the appendix was absent:
submitted to Licensorsubmitted to the Licensorreceived by Licensorreceived by the Licensorexcluding those noticesexcluding any noticesA modified Apache-2.0 is not Apache-2.0, and license scanners could not
identify it —
panascored 0/10 on "Use an OSI-approved license". Replacedwith the verbatim 201-line text, checked against two independent canonical
copies which agree on the whole operative section.
Version
0.2.0 to 0.3.0. Two breaking changes, matching the convention used for 0.2.0
which labelled a wire-format change breaking:
changedMaskadded to GATT characteristic props. Requires a matching nativelibrary rebuild.
startNotify()andstopNotify()now throw where they previously alwayssucceeded, when the Notifying property does not reach the requested state.
The changelog entry covers the notification-state fixes merged in #7 along
with the packaging changes here.
Packaging
hooksconstraint raised to^2.1.0. Verified rather than assumed: with.dart_tool/hooks_runnerremoved, the build hook rebuildslibbluez_nc.sofrom scratch under 2.x, analyzer is clean, and all tests pass.
only the first part, and
panawants 60 to 180.documentation:URL, which pointed at a pub.dev page that doesnot exist. pub.dev generates documentation once a package is published.
example/README.mddescribing each example and how to run it.Verification
dart pub publish --dry-runscripts/clang_tidy.sh)dart analyze/dart testAll gates re-run after the
hooksbump rather than before it.Note on tagging
publish.ymltriggers onv*.*.*and runsdart pub publish --force, butbluez_nativeis not yet on pub.dev. Automated publishing is configured perpackage on its pub.dev admin page, which requires the package to already
exist, so the first publish has to be done manually. Tagging before that is
likely to fail the publish job.