Skip to content

fix: keep multiple extras distinct in resolved pins - #297

Merged
jvolkman merged 2 commits into
jvolkman:mainfrom
eloisekp:eloise-extra-pins
Jul 23, 2026
Merged

fix: keep multiple extras distinct in resolved pins#297
jvolkman merged 2 commits into
jvolkman:mainfrom
eloisekp:eloise-extra-pins

Conversation

@eloisekp

Copy link
Copy Markdown
Contributor

The resolver keys pins by bare package name (parse_package_key(k).name), so
when a package is pinned with multiple extras (e.g. foo[bar] and foo[baz])
they collapse to a single foo entry and all but the last are silently dropped.

The downstream extras machinery in thin_package_repo.bzl already groups pins by
parts.extra and emits [extra] proxy targets — but it never sees any extras,
because the resolver strips them first. This keeps the extra in the pin key so
that path is actually fed, and references the [extra] proxy target when
rendering all_requirements.

Tested via _test_multi_extra_pins in the lock resolver suite.

@eloisekp
eloisekp force-pushed the eloise-extra-pins branch from f562236 to 2357080 Compare July 22, 2026 08:11
@jvolkman
jvolkman force-pushed the eloise-extra-pins branch from 2357080 to 8c2c49e Compare July 23, 2026 04:44
@jvolkman

Copy link
Copy Markdown
Owner

Thanks for catching that!

@jvolkman
jvolkman merged commit 74ee87c into jvolkman:main Jul 23, 2026
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants