Fix untouched geofence saves on mobile - #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Diagnosis
The page serialized each default radius as
0.00while also setting HTMLmin=0.10. Mobile browsers retain that numeric value and fail native constraint validation before POST, even when the slot is untouched. The POST handler also treated every emitted latitude field as a configured slot and silently clamped radius. The fix normalizes a fully untouched slot to empty form values and gates server validation on whether any field is provided.Validation
python -m unittest discover -s tools -p test_*.py(10 passed)git diff --checkThe repository has no web-portal test harness, so device/browser verification should use this regression matrix: