feat: remove numpy#120
Open
khauersp wants to merge 4 commits into
Open
Conversation
drewr95
approved these changes
Jun 8, 2026
Contributor
Author
|
I'm going to duplicate to the new fork |
Collaborator
| if len(list_of_arr) > 1: | ||
| data_list.append(list_of_arr[1].tolist()) | ||
| chunk_size = self.DataLength.TP | ||
| data_list = [list(data[i:i + chunk_size]) for i in range(0, data_length, chunk_size)] |
Collaborator
There was a problem hiding this comment.
Sorry for not knowing the answer to these questions already, but i was wondering:
- are these language constructs valid in all the versions of python that we currently support?
- is there any existing unit test coverage for this area of code that would alert us if anything was amiss?
Contributor
Author
There was a problem hiding this comment.
Test coverage is a bit lackluster so I'll add some tests on this branch. I believe so, from a quick search it looks like, range, list and the list comprehension to make the data_list functionality was all added back in python 2, it seems they changed a bit with python 3.0 but I believe they should be widely supported. I can't actually find what all versions we support, but it should work for python 3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove numpy dependency and replace it with just python logic