Skip to content

feat(models)!: remove retired ecmwf_aifs025_ensemble (contraction) #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
niasie wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(models)!: remove retired ecmwf_aifs025_ensemble (contraction) #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07fdf9d
feat(models)!: remove retired ecmwf_aifs025_ensemble
niasie Jun 26, 2026
e20ad84
test(models): assert retired ecmwf_aifs025_ensemble is gone
niasie Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/jua/weather/_model_meta.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,12 +242,6 @@ class ModelMetaInfo:
# num_lats=720 / num_lons=1440, so no override needed.
temporal_resolution=TemporalResolution(base=6),
)
_MODEL_META_INFO[Models.ECMWF_AIFS_ENSEMBLE] = ModelMetaInfo(
forecast_name_mapping="ecmwf_aifs025_ensemble",
full_forecasted_hours=360,
has_forecast_file_access=False,
has_statistics=True,
)
_MODEL_META_INFO[Models.ECMWF_IFS_ENSEMBLE] = ModelMetaInfo(
full_forecasted_hours=360,
has_forecast_file_access=False,
Expand Down
1 change: 0 additions & 1 deletion src/jua/weather/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ class Models(str, Enum):
NOAA_GFS_SINGLE = "noaa_gfs_single"

# Without Grid Access
ECMWF_AIFS_ENSEMBLE = "ecmwf_aifs025_ensemble"
ECMWF_IFS_ENSEMBLE = "ecmwf_ens"
GFS_GLOBAL_ENSEMBLE = "gfs_global_ensemble"
GFS_GLOBAL_SINGLE = "gfs_global_single"
Expand Down
16 changes: 11 additions & 5 deletions tests/weather/test_aifs_ens_meta.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
"""Regression tests for the hosted AIFS ENS model metadata.

The hosted ClickHouse ``aifs_ens`` model is added alongside the existing
open-meteo ``ecmwf_aifs025_ensemble`` (additive / expand phase). Unlike the
point-only open-meteo model, the hosted model exposes full grid access plus
ensemble statistics, so it must not regress into the "point queries only"
behaviour gated by ``has_grid_access``.
The hosted ClickHouse ``aifs_ens`` model replaced the retired open-meteo
``ecmwf_aifs025_ensemble``. Unlike that point-only open-meteo model, the hosted
model exposes full grid access plus ensemble statistics, so it must not regress
into the "point queries only" behaviour gated by ``has_grid_access``.
"""

from jua.weather._model_meta import get_model_meta_info
Expand All @@ -21,3 +20,10 @@ def test_aifs_ens_is_fully_accessible() -> None:
assert (meta.num_lats, meta.num_lons) == (720, 1440)
# 0-360h forecast horizon.
assert meta.full_forecasted_hours == 360


def test_retired_open_meteo_aifs_ensemble_is_removed() -> None:
# The open-meteo ecmwf_aifs025_ensemble was retired; only the hosted
# aifs_ens remains. Guard against the enum member being reintroduced.
assert not hasattr(Models, "ECMWF_AIFS_ENSEMBLE")
assert "ecmwf_aifs025_ensemble" not in {m.value for m in Models}
Loading