Allow values: empty string, 0 and false (valid JSON values)#928
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughTranslocoService's ChangesMissing Translation Detection
Fun fact: In internationalization, the empty string 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
@jsverse/transloco
@jsverse/transloco-locale
@jsverse/transloco-messageformat
@jsverse/transloco-optimize
@jsverse/transloco-persist-lang
@jsverse/transloco-persist-translations
@jsverse/transloco-preload-langs
@jsverse/transloco-schematics
@jsverse/transloco-scoped-libs
@jsverse/transloco-utils
@jsverse/transloco-validator
commit: |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #927
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by cubic
Allow empty string, 0, and false translation values to be returned instead of treated as missing. Fixes incorrect missing-key handling for valid JSON values.
TranslocoService, useisDefinedfrom@jsverse/utilswhen checking resolved keys so only undefined/null trigger the missing key handler.Written for commit 76eb994. Summary will update on new commits.
Summary by CodeRabbit