fix(#632) - Locale pipe optimization#637
Open
ben12 wants to merge 2 commits into
Open
Conversation
|
|
Contributor
Author
|
@shaharkazaz Ready for review |
Collaborator
|
@ben12 Thank you for the PR and the heads up, I missed this PR. |
e5e9a70 to
284694c
Compare
c068fa2 to
d2ade9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #632
What is the new behavior?
Locale pipes return last formatted value when value and parameters do not change.
Does this PR introduce a breaking change?
Other information
Using this measurement code (and same for Date, Percent and Currency):
Before optimization I get:
After optimization I get: