Public repo sharing (Phases 126-127)#113
Merged
Merged
Conversation
…eader, first-index gate, refresh throttle) Adds repos.visibility/owner_user_id and repo_grants.source columns, a gitsema repos visibility CLI command, and registration-flow logic in POST /api/v1/remote/index for auto-granting read access on public repos, gated by auth.allowPublicAutoIndex and throttled by auth.minReindexIntervalSeconds. Fixes a registry-DB/active-DB FK mismatch discovered during testing: registry.db (clone/index-path bookkeeping) and the active session DB (auth/grants) are independent SQLite files with separate FK-enforced users tables, so ownerUserId is now mirrored only into the active DB rather than written to both. Co-Authored-By: Claude Sonnet 4.6 <[email protected]> Claude-Session: https://claude.ai/code/session_01BYNogpqPb8oyTF3B5Ebu5p
…fixtures Hoist the duplicated non-owner-on-public-repo guard into a single named boolean, add TTL cleanup for the reindex throttle map (matching the existing jobs map pattern), and extract repeated test fixture setup into a shared helper. Co-Authored-By: Claude Sonnet 4.6 <[email protected]> Claude-Session: https://claude.ai/code/session_01BYNogpqPb8oyTF3B5Ebu5p
…as.md Adds a CLAUDE.md rule so skipped /simplify findings aren't lost to chat history, and backfills the two deferred findings from the Phase 126/127 public-repo-sharing simplify pass. Co-Authored-By: Claude Sonnet 4.6 <[email protected]> Claude-Session: https://claude.ai/code/session_01BYNogpqPb8oyTF3B5Ebu5p
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
…ronment Records that this environment lacks send_later and that CI success doesn't trigger a webhook, so PR-watching sessions need a manual ~7-minute poll loop instead. Co-Authored-By: Claude Sonnet 4.6 <[email protected]> Claude-Session: https://claude.ai/code/session_01BYNogpqPb8oyTF3B5Ebu5p
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
public/private(gitsema repos visibility <repo-id> public|private), auto-grantingreadaccess to non-owner callers who index an existing public repo, gated by a first-index allow-list (auth.allowPublicAutoIndex/GITSEMA_PUBLIC_AUTO_INDEX) and a per-user re-index throttle (auth.minReindexIntervalSeconds/GITSEMA_MIN_REINDEX_INTERVAL_SECONDS).ownerUserIdis only ever written to the active DB, never to the cwd-independent registry DB, since the latter has no matchingusersrow to satisfy its own FK constraint)./simplifycleanup pass: hoists a duplicated non-owner-on-public-repo guard into a single named boolean, adds TTL cleanup for the re-index throttle map (matching the existing_jobsmap pattern), and extracts repeated test fixture setup into a shared helper.CLAUDE.mdrule requiring/simplifypasses to log any skipped/deferred findings intodocs/feature-ideas.mdinstead of losing them to chat history, and backfills two such findings from this pass (rate-limiter unification, policy-extraction).Test plan
pnpm build— cleanpnpm test— full suite passes (1315 passed, 22 skipped)docs/features.md,README.md,docs/PLAN.md(phase marked complete with deviation notes),docs/parity.md,.changeset/public-repo-sharing.mdCo-Authored-By: Claude Sonnet 4.6 [email protected]
https://claude.ai/code/session_01BYNogpqPb8oyTF3B5Ebu5p
Generated by Claude Code