Fix stateful NON_LATIN1_REGEXP in createparams#128
Open
deepview-autofix wants to merge 1 commit into
Open
Conversation
The module-level NON_LATIN1_REGEXP has the /g flag, so calling `.test(fallback)` leaves `lastIndex` at the match position. A subsequent `create()` call with a non-ISO-8859-1 fallback would resume matching from that stale index, could miss earlier non-latin1 characters, and silently bypass the "fallback must be ISO-8859-1 string" validation - producing a Content-Disposition with non-latin1 bytes in filename=. Reset `lastIndex` to 0 before the `.test` call to keep the validation deterministic across invocations. Co-Authored-By: Claude <[email protected]> Co-Authored-By: DeepView Autofix <[email protected]> Co-Authored-By: Nikita Skovoroda <[email protected]> Signed-off-by: Nikita Skovoroda <[email protected]>
ChALkeR
reviewed
Apr 24, 2026
ChALkeR
left a comment
ChALkeR
left a comment
Contributor
There was a problem hiding this comment.
This is mine
Prior to the fix:
> require('content-disposition')('1.pdf', { fallback: '😭' })
Uncaught TypeError: fallback must be ISO-8859-1 string
> require('content-disposition')('1.pdf', { fallback: '😭' })
Uncaught TypeError: fallback must be ISO-8859-1 string
> require('content-disposition')('1.pdf', { fallback: '😭' })
`attachment; filename="😭"; filename*=UTF-8''1.pdf`
Member
|
It looks like this is an issue in the current released code, want to make a PR against 1.x branch instead? In the current main, that code will be going out in 2.x and I think it should just remove the |
Contributor
|
@blakeembrey will do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The module-level NON_LATIN1_REGEXP has the /g flag, so calling
.test(fallback)leaveslastIndexat the match position. A subsequentcreate()call with a non-ISO-8859-1 fallback would resume matching from that stale index, could miss earlier non-latin1 characters, and silently bypass the "fallback must be ISO-8859-1 string" validation - producing a Content-Disposition with non-latin1 bytes in filename=.Reset
lastIndexto 0 before the.testcall to keep the validation deterministic across invocations.