Migrate tests to testcontainers-go#107
Conversation
jschaf
left a comment
There was a problem hiding this comment.
Thanks, the approach looks okay. The big increase in indirect dependencies isn't amazing.
What do you think of using this instead? https://michael.stapelberg.ch/posts/2024-11-19-testing-with-go-and-postgresql-ephemeral-dbs/
| ) | ||
|
|
||
| // Client is a client to control the running Postgres Docker container. | ||
| const DefaultImage = "postgres:13-alpine" |
There was a problem hiding this comment.
internal/pgdocker was using 13
pggen/internal/pgdocker/template.go
Line 11 in 632aa8e
you think we should unify everything to 15? I'm down
There was a problem hiding this comment.
Let's jump to 17 if it's not too painful. Otherwise, 14 or 15 is fine, as those are both still supported.
13 is end of life.
| type Option func(config *pgx.ConnConfig) | ||
|
|
||
| const ( | ||
| postgresImage = "postgres:15-alpine" |
There was a problem hiding this comment.
Probably worth pulling to a test constant so we don't have different versions.
please take a look at #108 |
setting up a foundation for agentic solving of #99
prompt: