Skip to content

Catch HTTP errors from MAST outages in network tests #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jpdeleon merged 1 commit into from
Apr 9, 2026
Merged

Catch HTTP errors from MAST outages in network tests #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions tests/test_tql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,12 @@
from quicklook.tql import TessQuickLook
import lightkurve as lk
import astropy.units as u
import requests
from astroquery.exceptions import RemoteServiceError

# Network errors that indicate MAST/remote service issues, not code bugs.
_NETWORK_ERRORS = (RemoteServiceError, requests.exceptions.HTTPError, ConnectionError, TimeoutError)


@pytest.fixture
def planet_inputs():
Expand Down Expand Up @@ -69,8 +73,8 @@ def test_tql_planet(planet_inputs):
# Check that TLS was run
assert hasattr(ql, "tls_results")
assert ql.tls_results.period > 0
except RemoteServiceError as e:
# CI-specific soft failure
except _NETWORK_ERRORS as e:
# CI-specific soft failure — MAST outages are not code bugs
if os.getenv("CI", "false") == "true":
pytest.xfail(f"Network failure (not a bug): {e}")
else:
Expand Down Expand Up @@ -100,8 +104,8 @@ def test_tql_eb(eb_inputs):
# Check that TLS was run
assert hasattr(ql, "tls_results")
assert ql.tls_results.period > 0
except RemoteServiceError as e:
# CI-specific soft failure
except _NETWORK_ERRORS as e:
# CI-specific soft failure — MAST outages are not code bugs
if os.getenv("CI", "false") == "true":
pytest.xfail(f"Network failure (not a bug): {e}")
else:
Expand All @@ -122,8 +126,8 @@ def test_tql_variable_star(variable_star_inputs):
assert ql.sector == variable_star_inputs["sector"]
assert ql.flux_type == variable_star_inputs["flux_type"].lower()
assert ql.pipeline == variable_star_inputs["pipeline"].lower()
except RemoteServiceError as e:
# CI-specific soft failure
except _NETWORK_ERRORS as e:
# CI-specific soft failure — MAST outages are not code bugs
if os.getenv("CI", "false") == "true":
pytest.xfail(f"Network failure (not a bug): {e}")
else:
Expand Down
Loading