Renames FailedResult and SuccessResult -> Failure and Success#1
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR renames the FailedResult and SucceededResult classes to Failure and Success respectively, simplifying the naming convention for the result types. The changes also include package version updates.
- Renames
SucceededResult→SuccessandFailedResult→Failureacross the codebase - Updates test files to use the new class names
- Updates several package versions in Directory.Packages.props
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/JOS.Result/Success.cs | New file containing the renamed Success and Success<T> classes |
| src/JOS.Result/SucceededResult.cs | Removed file (replaced by Success.cs) |
| src/JOS.Result/Failure.cs | New file containing the renamed Failure and Failure<T> classes |
| src/JOS.Result/FailedResult.cs | Removed file (replaced by Failure.cs) |
| test/JOS.Result.Tests/ResultTests.cs | Updated test instantiations to use new class names |
| test/JOS.Result.Tests/ConversionTests.cs | Updated conversion tests to use new class names |
| Directory.Packages.props | Updated package versions for dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.